Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(gateway): enable subdomain conformance #246

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 31, 2023

This PR enables the subdomain conformance gateway tests (added in #237). Since we are using the CAR example to run the Gateway tests, we need to make it more conformant, of course, similarly to what happened in ipfs-inactive/bifrost-gateway#66.

  • Enables subdomain conformance tests on example.net (domain used in examples)
  • Adds CONNECT support to the gateway examples.
  • Extract the handler creation login into the common subpackage since it was the same for both examples.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #246 (0bc8590) into main (b01359c) will increase coverage by 0.28%.
The diff coverage is 90.62%.

❗ Current head 0bc8590 differs from pull request most recent head 725a8f4. Consider uploading reports for the commit 725a8f4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   47.87%   48.15%   +0.28%     
==========================================
  Files         269      269              
  Lines       32976    32957      -19     
==========================================
+ Hits        15787    15871      +84     
+ Misses      15514    15422      -92     
+ Partials     1675     1664      -11     
Impacted Files Coverage Δ
examples/gateway/car/main.go 14.63% <0.00%> (+6.63%) ⬆️
examples/gateway/proxy/main.go 0.00% <0.00%> (ø)
examples/gateway/common/http.go 93.54% <93.54%> (ø)

... and 12 files with indirect coverage changes

Base automatically changed from ci/gateway-conformance to main March 31, 2023 08:13
@hacdias hacdias force-pushed the ci/gateway-conformance-subdomain branch 2 times, most recently from 0bc8590 to d95ed57 Compare March 31, 2023 08:46
@hacdias hacdias marked this pull request as ready for review March 31, 2023 08:58
@hacdias hacdias requested review from lidel and a team as code owners March 31, 2023 08:58
@hacdias hacdias enabled auto-merge (rebase) March 31, 2023 08:59
@hacdias hacdias force-pushed the ci/gateway-conformance-subdomain branch from 0862a5f to 725a8f4 Compare March 31, 2023 09:38
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚢

(while looking at this, found unrelated nit: #176 (review))

@hacdias hacdias merged commit 2835752 into main Mar 31, 2023
@hacdias hacdias deleted the ci/gateway-conformance-subdomain branch March 31, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants